Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pass-style): Avoid name convention conflict #2666

Merged
merged 4 commits into from
Dec 20, 2024
Merged

refactor(pass-style): Avoid name convention conflict #2666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8998ca7
refactor(pass-style): Avoid name convention conflict
erights Dec 19, 2024
7b8ea27
fixup! update lint rule to complain on violation
erights Dec 20, 2024
eeddd08
fixup! format
erights Dec 20, 2024
849624e
fixup! review suggestion
erights Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/eslint-plugin/lib/configs/internal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,17 @@ module.exports = {
// RESM does not support ?? nor ?. operators, so we must avoid them expressly.
'@endo/no-optional-chaining': 'error',
'@endo/no-nullish-coalescing': 'error',
'@typescript-eslint/naming-convention': [
'error',
{
selector: 'interface',
format: ['PascalCase'],
custom: {
regex: '.*I$',
match: false,
},
},
],
},
overrides: [
{
Expand Down
12 changes: 6 additions & 6 deletions packages/pass-style/src/types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,14 +85,14 @@ export type Passable<
> = void | Primitive | Container<PC, E> | PC | E;

export type Container<PC extends PassableCap, E extends Error> =
| CopyArrayI<PC, E>
| CopyRecordI<PC, E>
| CopyTaggedI<PC, E>;
interface CopyArrayI<PC extends PassableCap, E extends Error>
| CopyArrayInterface<PC, E>
| CopyRecordInterface<PC, E>
| CopyTaggedInterface<PC, E>;
interface CopyArrayInterface<PC extends PassableCap, E extends Error>
extends CopyArray<Passable<PC, E>> {}
interface CopyRecordI<PC extends PassableCap, E extends Error>
interface CopyRecordInterface<PC extends PassableCap, E extends Error>
extends CopyRecord<Passable<PC, E>> {}
interface CopyTaggedI<PC extends PassableCap, E extends Error>
interface CopyTaggedInterface<PC extends PassableCap, E extends Error>
extends CopyTagged<string, Passable<PC, E>> {}

export type PassStyleOf = {
Expand Down
Loading