feat(daemon): Rename Locator to Config, improve type exports #2212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is also a touch-point in |
kriskowal
approved these changes
Apr 15, 2024
rekmarks
force-pushed
the
rekmarks-old-locator-is-now-config
branch
from
fd08ae4 to
d5d9bc6
Compare
Renames the daemon's `Locator`, used to specify its file and storage paths, to `Config` to get rid of the name collision with endo locator strings.
Adds return values for exported functions in `./types.d.ts`, and removes redundant definition of `Config` type.
rekmarks
force-pushed
the
rekmarks-old-locator-is-now-config
branch
from
d5d9bc6 to
89d4a2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames the daemon's
Locator, used to specify its file and storage paths, toConfigto get rid of the name collision with endo locator strings. Also adds return values to functions in exported types, and removes redundant definition ofConfigtype.