refactor(daemon): Fix naming issues in multimap interface #2193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
commented
Mar 30, 2024
Comment on lines
-102
to
-104
| get: value => valueForKey.get(value), | ||
| get: key => keyForValues.get(key), | ||
|
|
||
| getValue: key => keyForValues.get(key), |
There was a problem hiding this comment.
I made this unfortunate mistake when addressing feedback to a previous PR.
rekmarks
force-pushed
the
rekmarks-multi-bimap-fixes
branch
from
aec68a5 to
13bbec1
Compare
kriskowal
approved these changes
Apr 3, 2024
Addresses some naming issues in the multimap's interface and adds missing test cases.
rekmarks
force-pushed
the
rekmarks-multi-bimap-fixes
branch
from
13bbec1 to
89524a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses some naming issues in the multimap's interface and adds missing test cases.