refactor(daemon): Add known-peers-store formula #2179
Merged
+50
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the known peers store adapter with a dedicated `known-peers-store` formula type, instantiated the same way as other "special" formulas such as `least-authority`. The adapter used a `pet-store` formula under the hood. Giving it a different formula entirely is probably less likely to confuse us in the future.
kriskowal
approved these changes
Mar 25, 2024
| 'known-peers-store', | ||
| // The known peers store is just a pet store that only accepts node identifiers | ||
| // (i.e. formula numbers) as "names". | ||
| assertValidNumber, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2166
Replace the known peers store adapter with a dedicated
known-peers-storeformula type, instantiated the same way as other "special" formulas such asleast-authority. The adapter used apet-storeformula under the hood. Giving it a different formula entirely is probably less likely to confuse us in the future.