refactor(daemon): Synchronize makeGuest #2120
Conversation
| // TODO: Return early if the formula identifier is the same. | ||
| if (petNames.has(petName)) { | ||
| // Perform cleanup on the overwritten pet name. | ||
| const formulaPetNames = formulaIdentifiers.get(petName); | ||
| if (formulaPetNames !== undefined) { | ||
| formulaPetNames.delete(petName); | ||
| } | ||
| // TODO: Should this only happen if something is actually deleted? |
There was a problem hiding this comment.
I noticed these couple oddities in the pet store's write(). I'll create an issue if we agree that there's something to do.
There was a problem hiding this comment.
@kriskowal thoughts on these?
There was a problem hiding this comment.
It would somewhat simplify client code if they are assured that they only see delete messages for equal but opposite prior add.
rekmarks
force-pushed
the
rekmarks-synchronize-makeGuest
branch
from
acaf382 to
45e718a
Compare
rekmarks
force-pushed
the
rekmarks-synchronize-makeGuest
branch
from
45e718a to
14ae908
Compare
packages/daemon/src/async-hooks.js
Outdated
| /** | ||
| * @returns {import('./types.js').AsyncHooks<any>} | ||
| */ | ||
| export const makeAsyncHooks = () => { |
There was a problem hiding this comment.
There’s a Node.js module by the same name that we don’t want to confuse this with. This is similar to a WaitGroup in Go. I think DeferredSet might be good.
There was a problem hiding this comment.
I went with deferredTasks.
| return { | ||
| value: Promise.resolve(value), |
There was a problem hiding this comment.
Is the type system demanding we wrap these? Maybe we should use Awaited<T> somewhere.
There was a problem hiding this comment.
The type system does demand this. Since this was already here, I'll leave it for now. Should we create an issue?
There was a problem hiding this comment.
Meh. Not big enough to track.
Synchronizes the daemon's incarnateGuest(). Replaces incarnateHandle() and incarnatePetStore() with their "incarnateNumbered" equivalents.
rekmarks
force-pushed
the
rekmarks-synchronize-makeGuest
branch
from
14ae908 to
f546680
Compare
Progresses: #2086
Synchronizes the host's
makeGuest()and its dependencies. See #2086 for details.