refactor(daemon,cli): Consolidate pet name list commands #2102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskowal
force-pushed
the
kriskowal-consolidate-list
branch
3 times, most recently
from
2661df4 to
39c4d1a
Compare
kriskowal
commented
Feb 27, 2024
| if (directoryName !== undefined) { | ||
| party = E(party).lookup(directoryName); | ||
| if (directoryPath !== undefined) { | ||
| party = E(party).lookup(...directoryPath.split('.')); |
There was a problem hiding this comment.
I tacked on this fix for dot delimited lookup at the CLI.
kriskowal
force-pushed
the
kriskowal-consolidate-list
branch
3 times, most recently
from
8c63fb1 to
d0af822
Compare
kumavis
approved these changes
Feb 28, 2024
kriskowal
force-pushed
the
kriskowal-consolidate-list
branch
from
d0af822 to
90e756a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reverses a choice I made earlier, merged by #2068, where I elected to simplify the daemon’s list API to just have one
list()method for each type of directory, name hub, or agent, guest, or host. I think if we want filters in the future, we can recover them in the CLI alone.