style(pass-style): Reduce nesting depth for input validation #2097
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reduce the nesting depth for input validation by defining
reject
s as tag functions rather than traditional wrappers.Security Considerations
n/a
Scaling Considerations
Constructing details is already in the slow path exercised only with an explicit check function, and introducing rest/spread to the wrapper imposes minor additional cost (the
reject
call itself gets about 6% slower on XS and 20% slower on V8). We could probably do better by passingreject
functions rather than constructing them at each level, but that would affect the public API so I'm not contemplating that here.Documentation Considerations
n/a
Testing Considerations
n/a
Compatibility Considerations
n/a
Upgrade Considerations
n/a
Includes*BREAKING*:
in the commit message with migration instructions for any breaking change.UpdatesNEWS.md
for user-facing changes.