test(patterns,exo): pre-tests of upcoming #2038 #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
force-pushed
the
markm-8826-test-old-guard-tolerance
branch
from
350c1ca to
321156b
Compare
mhofman
reviewed
Feb 7, 2024
2 tasks
Chris-Hibbert
approved these changes
Feb 7, 2024
erights
force-pushed
the
markm-8826-test-old-guard-tolerance
branch
from
bf73f5e to
a0ed14e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #XXXX
refs: Agoric/agoric-sdk#8826 #2038
Description
Tests the compat failure behavior prior to #2038 that we believe is the cause behind our current understanding of Agoric/agoric-sdk#8826 . Sets things up so that #2038 's differences in behavior, to give us the compat Agoric/agoric-sdk#8826 needs, can be demonstrated by the changes it must make to these tests so they will pass again.
Security Considerations
Since this PR is only adding tests, none. But see considerations in #2038
Scaling Considerations
Since this PR is only adding tests, none. But see considerations in #2038
Documentation Considerations
Since this PR is only adding tests, none. But see considerations in #2038
Testing Considerations
The whole point of this PR. See the description. But these are just for unit testing compat problems that we believe cause Agoric/agoric-sdk#8826 . It does not even think about doing the needed integration tests.
Compatibility Considerations
Since this PR is only adding tests, none. But the point of #2038 is to repair some of these incompatibilities.
Upgrade Considerations
Since this PR is only adding tests, none. But the point of #2038 is to repair some of these incompatibilities, which we believe are breaking the upgrade needed by Agoric/agoric-sdk#8826 .
*BREAKING*:in the commit message with migration instructions for any breaking change.NEWS.mdfor user-facing changes.