feat(cli): Add install --open flag #2015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskowal
commented
Jan 27, 2024
packages/cli/demo/README.md
Outdated
| @@ -258,11 +258,16 @@ _Familiar Chat_ is an example application that provides a web app for | |||
| interacting with your pet daemon. | |||
|
|
|||
| ``` | |||
| > endo open familiar-chat cat.js --powers HOST | |||
| > endo install familiar-chat cat.js --powers HOST | |||
There was a problem hiding this comment.
I could see an argument that this might be a more predictable usage if shaped more like other commands: endo install cat.js --powers HOST --name familiar-chat, but the --name flag is not optional for install. If that’s preferable to others, I’d consider doing that in a follow-up change.
kriskowal
force-pushed
the
kriskowal-cli-install-and-open
branch
from
ef07469 to
472cc60
Compare
rekmarks
requested changes
Jan 27, 2024
kriskowal
force-pushed
the
kriskowal-cli-install-and-open
branch
from
472cc60 to
3a4fc45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buzz a sharp corner off of the
installandopenworkflow by allowing them to be combined into a single command.