feat(cli)!: Rename --UNSAFE to --UNCONFINED #2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renames the `UNSAFE` flag to `UNCONFINED`, which is more specific.
rekmarks
force-pushed
the
rekmarks-unconfined-not-unsafe
branch
from
f9aa898 to
ba33e82
Compare
kriskowal
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Cool, to cut all the way down to the bone, I would like to rename importUnsafeAndEndow to makeUnconfined and importBundleAndEndow to merely makeBundle throughout the daemon.js. I would also like to rename the formula types, import-unsafe and import-bundle to merely make-unconfined and make-bundle. These changes will necessitate an endo purge --force, but c’est la mode.
Renames all internals that use "unsafe" in their names to use "unconfined" instead. Will require an `endo purge -f`.
kriskowal
approved these changes
Jan 26, 2024
rekmarks
force-pushed
the
rekmarks-unconfined-not-unsafe
branch
from
556ffe0 to
5ca7331
Compare
|
an lo! there was great rejoicing! thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames the
UNSAFEflag toUNCONFINED, which is more specific. Also renames internals using "unsafe" (likeimport-unsafe) to use "unconfined" instead.Will require an
endo purge -f.