refactor(daemon,cli): Rename capitalized names and arguments #2010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Uncapitalizes all "special names" in the daemon, since we have determined we no longer need this. - Renames the `--UNSAFE` CLI flag to `--UNCONFINED`, which is more specific. We maintain capitalization here to draw attention to it.
rekmarks
force-pushed
the
rekmarks-update-capitalized-names
branch
from
a95609d to
e290f86
Compare
kriskowal
requested changes
Jan 26, 2024
There was a problem hiding this comment.
I’ve miscommunicated again!
We do actually need special names to be capitalized to distinguish them from pet names in the pet store. For example, the name HOST is not deletable whereas host can be assigned.
There is no need for the third term in INFO.host.worker to be capitalized under a pet inspector.
|
(Renaming |
|
Alas dear PR, I barely knew ye... |
|
I should also clarify that the design requirement is that special names and pet names need to be distinguishable. This is just the convention of the day and can be changed. We want pet names to have a much more broad range. The distinguisher could be something else. A dot prefix ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--UNSAFECLI flag to--UNCONFINED, which is more specific. We maintain capitalization here to draw attention to it.