chore(compartment-mapper): fix type of internal function #1994
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the
@ts-ignore
found inmakeFauxModuleExportsNamespace()
, which was renamed frommakeFeauxModuleExportsNamespace()
, because "féaux" translates to "loyal supporters" and not "fake" or "false" like was presumably intended.I am not so bold to rename it
makeErsatzModuleExportsNamespace()
, despite "ersatz" being a wholly superior word to either of the above alternatives.Anyway, this adds a proper type signature and fixes the return type; the
importHook
prop of the returned value did not adhere to the definition ofImportHook
. Likewise,StaticModuleType
demands anexports
array.Given this apparently worked just fine before I changed it, one could argue the types ought to be loosened somewhat.