Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Reminders for compatibility concerns #1992

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

kriskowal
Copy link
Member

Adds considerations to pull request and issue templates to remind us about compatibility concerns.

Copy link
Contributor

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me...

but approval should come from folks that bear the burden of writing and reviewing most of the PRs around here

Copy link
Contributor

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one suggestion:

Move the Compat Concerns section to immediately above the Upgrade considerations, since they're closely related.

@kriskowal kriskowal force-pushed the kriskowal-compatibility-templates branch from 55e371e to 73fa5ab Compare January 23, 2024 01:11
@kriskowal kriskowal force-pushed the kriskowal-compatibility-templates branch from 73fa5ab to 039fce5 Compare January 23, 2024 01:26
@kriskowal kriskowal merged commit 7a21971 into master Jan 23, 2024
14 checks passed
@kriskowal kriskowal deleted the kriskowal-compatibility-templates branch January 23, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants