refactor(ses): Move makeLRUCacheMap to a dedicated file #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibson042
force-pushed
the
gibson-2024-01-move-lru-cachemap
branch
from
778c03e to
ad116cd
Compare
erights
approved these changes
Jan 20, 2024
There was a problem hiding this comment.
LGTM, much better, thanks!
Given that it has to work before lockdown, it itself does not to be exported in that form. Rather, a trivial but post-lockdown wrapper of this could be what it exported.
OTOH, given adequate use of freeze to emulate full hardening, exporting from a lower layer package is fine. As you say, it cannot be @endo/common because of this layering. In any case, this PR is the right first step.
It should eventually be an endo export, possibly in its own package (just not in `common`, which itself depends upon `ses`).
gibson042
force-pushed
the
gibson-2024-01-move-lru-cachemap
branch
from
ad116cd to
1adcc57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
makeLRUCacheMapis only used by the SES error system, but is not really specific to it. It should eventually be an endo export, possibly in its own package (just not incommon, which itself depends uponses), but this PR just promotes it up one level into an easily-movable file for when that time comes.Security Considerations
This code is depended upon by SES assert code, and therefore cannot itself assume a hardened environment. All of the existing commentary and
freezecalls were preserved.Scaling Considerations
n/a
Documentation Considerations
None yet.
Testing Considerations
Testing was consolidated into packages/ses/test/test-lru-cache-map.js.
Upgrade Considerations
n/a