refactor(ses): cleaner enable-property-overrides #1975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Got it wrong. Back to draft for the moment. |
erights
force-pushed
the
markm-refactor-enable-prop-override
branch
from
b826b7a to
ea77b9b
Compare
|
Fixed. I followed exactly your original suggestion. My attempted improvement was just confused. Ready for review again. Btw, I squashed which seems harmless for this review. |
mhofman
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #XXXX
refs: #1969
Description
At #1969 (review) @mhofman suggests:
Because it is so separate, I made it into a this separate PR.
At #1969 (comment) @mhofman suggests better code for that part of #1969. This PR uses that suggestion.
Security Considerations
none
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
none
Upgrade Considerations
none