feat(ses): Anticipate set-methods proposal #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
force-pushed
the
markm-some-properties-already-override-protected
branch
2 times, most recently
from
a394a2a to
a1a42e8
Compare
erights
force-pushed
the
markm-anticipate-set-methods
branch
from
2ebdbef to
53da0ca
Compare
FUDCo
approved these changes
Jan 16, 2024
erights
force-pushed
the
markm-some-properties-already-override-protected
branch
from
a1a42e8 to
b0f496f
Compare
erights
changed the base branch from
markm-some-properties-already-override-protected
to
master
erights
force-pushed
the
markm-anticipate-set-methods
branch
from
53da0ca to
ed9539f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #XXXX
refs: #1969 https://github.com/tc39/proposal-set-methods
Description
Anticipates https://github.com/tc39/proposal-set-methods .
While doing #1969, I noticed
on the Chrome Canary console, which is SES letting us developers know that it encountered properties that it did not previously know about. No security problem, because they were all successfully removed. But the warning lets us know that we should decide what to do about these properties, including explicitly deciding that they should be deleted.
In this case, the properties are from the set-methods proposal, that we participated in at tc39 and are satisfied is safe. This PR permits them, so that SES no longer removes them.
With this PR on top of #1969, Chrome Canary's console is clean.
Security Considerations
If we missed or misunderstood something about how these set-methods behave, or of an engine's implementation did, then permitting them could introduce a new security problem. But we have no particular reason to worry about these.
Scaling Considerations
Having efficient set operations will be nice, and may eventually help us make some things faster.
Documentation Considerations
none
Testing Considerations
none
Upgrade Considerations
none