Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(exo): ContextProvider typing #1966

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

erights
Copy link
Contributor

@erights erights commented Jan 15, 2024

closes: #XXXX
refs: #1925 Agoric/agoric-sdk#8752

Description

A ContextProvider is a function from an instance to a Context or undefined. But the type did not include the undefined.

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

Copy link
Contributor

@FUDCo FUDCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya shoor. You betcha.

@erights erights force-pushed the markm-context-provider-typing branch from a258703 to cbe1843 Compare January 16, 2024 19:10
@erights erights changed the base branch from markm-exo-is-live-instance to master January 16, 2024 19:10
@erights erights force-pushed the markm-context-provider-typing branch from cbe1843 to ad2cc41 Compare January 16, 2024 19:13
@erights erights enabled auto-merge (squash) January 16, 2024 19:16
@erights erights merged commit 99107d4 into master Jan 16, 2024
14 checks passed
@erights erights deleted the markm-context-provider-typing branch January 16, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants