fix(bundle-source): Accommodate Windows lack of atomic rename #1957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskowal
force-pushed
the
kriskowal-1955
branch
3 times, most recently
from
8182d54 to
4d913ff
Compare
kriskowal
force-pushed
the
kriskowal-1955
branch
from
4d913ff to
48135aa
Compare
mhofman
approved these changes
Jan 11, 2024
The race occurs if there are concurrent reads and writes for the same cache entry. The reader can encounter a partial bundle. But, I won’t pretend that I’ve thought this through completely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1955
Windows rename is not atomic and fails if the target exists. Our CI revealed this to us because it cached a bundle.