feat(ses): group removal cleanup diagnostics #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
force-pushed
the
markm-1345-group-removal-cleanup-diagnostics
branch
from
4cae174 to
9cdb792
Compare
kriskowal
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Thank you for taking this ticket.
For the record, I see that console.groupCollapsed is pretty universal.
erights
force-pushed
the
markm-test-cleanup-diagnostics
branch
from
f10bccf to
fd0c811
Compare
erights
force-pushed
the
markm-1345-group-removal-cleanup-diagnostics
branch
from
9cdb792 to
a4685d8
Compare
erights
force-pushed
the
markm-1345-group-removal-cleanup-diagnostics
branch
from
a4685d8 to
173ec8e
Compare
This was referenced Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staged on #1941
closes: #1345
refs: #1941
Description
Places all intrinsics removal cleanup diagnostics into a collapsed console group.
Attn @Jack-Works
Security Considerations
none
Scaling Considerations
none
Documentation Considerations
We should mention somewhere what this diagnostic means. Even though it is less visible, because it is now in a collapsed group, it is still purposely visible on the console output and people should be able to find out what it means --- and to know when to bring it to our attention.
Testing Considerations
none
Upgrade Considerations
none