feat: explicitly harden some shared prototypes #1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofman
force-pushed
the
mhofman/explicit-harden
branch
from
dd18c5a to
1fedbe1
Compare
|
Nope I'm an idiot, I forgot a line in my refactor |
mhofman
force-pushed
the
mhofman/explicit-harden
branch
from
1fedbe1 to
87d0f65
Compare
erights
approved these changes
Jan 9, 2024
packages/ses-ava/src/ses-ava-test.js
Outdated
| @@ -75,6 +75,16 @@ const overrideList = [ | |||
| 'only', | |||
| ]; | |||
|
|
|||
| // Helper to explicitely harden an object including its prototype chain | |||
mhofman
force-pushed
the
mhofman/explicit-harden
branch
from
87d0f65 to
148f101
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #1914
Description
While working on #1686, I found out that some shared prototypes are currently hardened as a side effect of an instance being hardened. This PR adds explicit harden for these.
It also contains a small refactor to harden all intrinsics in one shot instead of multiple calls to
harden, as there are cycles in those, and some intrinsics were effectively hardened in other calls.Security Considerations
More explicit hardening brings more security
Scaling Considerations
None
Documentation Considerations
In Node.js, the
Bufferand when the console is untamed, the internalSafeMapare now explicitly hardened. These would likely get hardened as side-effect of hardening instances before.Testing Considerations
Tested in #1914 and Agoric/agoric-sdk#8700 that these are all prototypes found through instances by existing tests. There may be others lurking, but until we have shallow hardening implemented, we won't find them.
Upgrade Considerations
This is a non breaking change that should be mostly unobservable to consumers.