fix(ses): Support an incomplete shimmed globalThis.process #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibson042
changed the title
mhofman
requested changes
Jan 3, 2024
kriskowal
approved these changes
Jan 3, 2024
| const globalProcess = aGlobal.process || undefined; | ||
| const globalEnv = | ||
| (typeof globalProcess === 'object' && globalProcess.env) || undefined; | ||
| if (typeof globalEnv === 'object') { |
There was a problem hiding this comment.
I believe this regresses if env === null. Unlikely, I’m sure.
There was a problem hiding this comment.
It doesn't given the || undefined
| @@ -10,7 +10,7 @@ let abandon; | |||
| // below). Currently it only checks for the `process.abort` or `process.exit` | |||
| // found on Node. It should also sniff for a vat terminating function expected | |||
| // to be found within the start compartment of SwingSet vats. What else? | |||
| if (typeof process === 'object') { | |||
| if (process && typeof process === 'object') { | |||
There was a problem hiding this comment.
Perhaps invert the order these so we don’t get a ReferenceError if process is not defined in scope.
| if ( | ||
| errorTrapping !== 'none' && | ||
| typeof globalProcess === 'object' && | ||
| typeof globalProcess.on === 'function' |
There was a problem hiding this comment.
Should test for existence of abort and exit as well.
|
@mhofman ready for re-review. |
|
Eager to land! Thanks. |
gibson042
force-pushed
the
gibson-1917-shimmed-process
branch
from
25ba699 to
08cbae5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1917
Description
Updates packages/ses/src/error/tame-console.js to check for a
globalThis.process.onfunction rather than assuming it whenglobalThis.processis defined.Also updates general patterns for checking
globalThisproperties for better uniformity.Security Considerations
n/a
Scaling Considerations
n/a
Documentation Considerations
n/a
Testing Considerations
n/a
Upgrade Considerations
n/a