feat(daemon): Undeniable host INFO tool #1916

kriskowal · 2023-12-29T22:40:20Z

Problem: Commands like endo make counter.js --name counter implicitly create a unique worker for the counter. This makes it impossible to address the worker for follow-up commands, like an eval co-located with the counter.

This change introduces an undeniable INFO name to all hosts that allows the host to address the values used to create pet named values. For example, INFO -> counter -> worker addresses the worker that was used to create counter. Until we have pet name path lookup (#1915), you need multiple invocations of E() to perform of depth greater than 1, for example:

> endo make counter.js --name counter
  Object [Alleged: Counter] {}
> endo eval 'E(INFO).lookup("counter")' INFO --name inspector
  Object [Alleged: Inspector (make-bundle ... )]
> endo eval 'E(inspector).lookup("worker")' inspector
  Object [Alleged: EndoWorker] {}

This facility is intended to compose well with follow-up changes for inspecting a worker’s log or copy one of these “unnamed” capabilities to a name.

dckc

looks plausible. I don't see any correctness issues.

without tests, I defer to others to approve

packages/daemon/src/daemon.js

kumavis

I'd like to see types for these interfaces. I'd also suggest that because we control all these keys (no user specified keys), they don't need to be capitalized

eval
  SOURCE
  WORKER
  ENDOWMENTS
import-unsafe
  SPECIFIER
  WORKER
  POWERS
import-bundle
  WORKER
  BUNDLE
  POWERS
guest
  HOST
web-bundle
  BUNDLE
  POWERS

- Updates INFO-related internals to refer to "inspector" instead of "info". - Adds types for different "known" inspectors (e.g. for `eval` formulas). - Lower-cases known inspector special names (e.g. `bundle`).

rekmarks · 2024-01-30T17:59:00Z

packages/daemon/test/test-endo.js

+// TODO: This test verifies existing behavior when pet-naming workers.
+// This behavior is undesirable.
+test('eval-mediated worker name', async t => {


I went for a passing test rather than test.failing() because the test could otherwise start to fail for an unexpected reason.

Issue for this: #2021

We like embedding links to issues in the code, especially for something like this.

rekmarks · 2024-01-30T18:01:34Z

packages/daemon/src/daemon.js

+    /**
+     * @param {string} petName - The pet name to inspect.
+     * @returns {Promise<import('./types').KnownEndoInspectors[string]>} An
+     * inspector for the value of the given pet name.
+     */
+    const lookup = async petName => {


We have types for the individual known inspectors (see types.d.ts), but due to the indirection between the petName argument and the formulaType, it is difficult (impossible?) to map the petName to the "correct" return type.

Agreed. We can’t be more specific than a union of all known inspector types. Lookup in general has this limitation. For some Endo APIs, we could overload a formula type argument and provide guarantees of specific types, to make some casts unnecessary.

kriskowal

I approve, but as the author can’t authorize a merge. Need a second opinion, possibly from coauthor @rekmarks, better from @kumavis.

kriskowal · 2024-01-30T19:52:08Z

packages/daemon/src/formula-identifier.js

@@ -1,10 +1,11 @@
 const { quote: q } = assert;

 const numberlessFormulasIdentifiers = new Set([
-  'pet-store',
-  'host',
  'endo',


Could add a comment that these are sorted, to maintain that invariant.

I'll defer this to when I look into our lint configs.

kriskowal · 2024-01-30T19:53:27Z

packages/daemon/test/test-endo.js

+// TODO: This test verifies existing behavior when pet-naming workers.
+// This behavior is undesirable.
+test('eval-mediated worker name', async t => {


We like embedding links to issues in the code, especially for something like this.

kumavis

whee

kriskowal requested review from dckc and kumavis December 29, 2023 22:40

dckc reviewed Dec 29, 2023

View reviewed changes

packages/daemon/src/daemon.js Outdated Show resolved Hide resolved

packages/daemon/src/daemon.js Outdated Show resolved Hide resolved

kriskowal assigned kriskowal and kumavis and unassigned kriskowal Jan 5, 2024

kumavis requested changes Jan 19, 2024

View reviewed changes

packages/daemon/src/daemon.js Outdated Show resolved Hide resolved

kumavis requested changes Jan 19, 2024

View reviewed changes

kumavis mentioned this pull request Jan 22, 2024

Endo Daemon: familiar chat ui (continued) #1877

Draft

14 tasks

rekmarks assigned rekmarks and unassigned kumavis Jan 23, 2024

rekmarks force-pushed the kriskowal-daemon-inspector branch from d149e64 to c369498 Compare January 23, 2024 06:35

rekmarks marked this pull request as draft January 23, 2024 06:36

rekmarks force-pushed the kriskowal-daemon-inspector branch 2 times, most recently from ae27dc1 to 1362fd8 Compare January 25, 2024 04:24

kriskowal and others added 3 commits January 25, 2024 22:19

feat(daemon): Undeniable host INFO tool

3c2d924

refactor(daemon): Use parseFormulaIdentifier in makeIdentifiedInspector

c23dc27

fix(daemon): Support pet-inspector in parseFormulaIdentifier

d0eaab1

rekmarks force-pushed the kriskowal-daemon-inspector branch 3 times, most recently from b4ba0f9 to aeac064 Compare January 30, 2024 07:18

rekmarks added 2 commits January 30, 2024 09:54

feat(daemon): Add inspector types

e7898f0

- Updates INFO-related internals to refer to "inspector" instead of "info". - Adds types for different "known" inspectors (e.g. for `eval` formulas). - Lower-cases known inspector special names (e.g. `bundle`).

test(daemon): Add inspector naming and reuse test

d43e1bd

rekmarks force-pushed the kriskowal-daemon-inspector branch from 7f4adfb to 585e17d Compare January 30, 2024 17:56

rekmarks reviewed Jan 30, 2024

View reviewed changes

rekmarks requested a review from kumavis January 30, 2024 18:43

rekmarks marked this pull request as ready for review January 30, 2024 18:44

rekmarks mentioned this pull request Jan 30, 2024

daemon: eval-mediated worker names do not resolve #2021

Open

kriskowal commented Jan 30, 2024

View reviewed changes

kumavis approved these changes Jan 30, 2024

View reviewed changes

test(daemon): Add test for eval-mediated worker names

4b45a7a

rekmarks force-pushed the kriskowal-daemon-inspector branch from 585e17d to 4b45a7a Compare January 30, 2024 22:50

rekmarks merged commit c2f3c9a into endo Jan 30, 2024
14 checks passed

rekmarks deleted the kriskowal-daemon-inspector branch January 30, 2024 23:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(daemon): Undeniable host INFO tool #1916

feat(daemon): Undeniable host INFO tool #1916

kriskowal commented Dec 29, 2023 •

edited by rekmarks

Loading

dckc left a comment

kumavis left a comment

rekmarks Jan 30, 2024

rekmarks Jan 30, 2024

kriskowal Jan 30, 2024

rekmarks Jan 30, 2024

kriskowal Jan 30, 2024

kriskowal left a comment

kriskowal Jan 30, 2024

rekmarks Jan 30, 2024

kriskowal Jan 30, 2024

kumavis left a comment

feat(daemon): Undeniable host INFO tool #1916

feat(daemon): Undeniable host INFO tool #1916

Conversation

kriskowal commented Dec 29, 2023 • edited by rekmarks Loading

dckc left a comment

Choose a reason for hiding this comment

kumavis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kriskowal left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kumavis left a comment

Choose a reason for hiding this comment

kriskowal commented Dec 29, 2023 •

edited by rekmarks

Loading