Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Expressly forbid deep imports through captp, far, lockdown, marshal #1907

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

kriskowal
Copy link
Member

To limit exposure to Hyrum’s Law, this change introduces an "exports" property to the four packages in Endo that currently lack one. Node.js 16+ and Endo’s bundler forbid deep imports to modules not expressly mentioned in "exports".

Copy link
Contributor

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kriskowal kriskowal merged commit 3699cf1 into master Dec 20, 2023
14 checks passed
@kriskowal kriskowal deleted the kriskowal-forbid-deep-exports branch December 20, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants