Avoid null coalescing and optional chaining #1905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
approved these changes
Dec 19, 2023
kriskowal
force-pushed
the
kriskowal-avoid-null-coalescing-and-optional-chaining
branch
from
c1e4983 to
3e689d2
Compare
kriskowal
force-pushed
the
kriskowal-avoid-null-coalescing-and-optional-chaining
branch
from
3e689d2 to
3355c04
Compare
kriskowal
deleted the
kriskowal-avoid-null-coalescing-and-optional-chaining
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agoric’s load generator test uses
node -r esmwhich doesn’t support the??nor?.operators.This change introduces a lint rule to help us avoid this trip-fall and then ensures that existing packages pass the new rules.