Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #XXXX
refs: #1890 (comment)
Description
At #1890 (comment) @kriskowal writes
Indeed, this PR is a result of running
yarn
on current endo master, and seems to reproduce the same changes. I do not offer my own opinion on whether these changes are correct, and depend fully on my reviewers.Security Considerations
yarn.lock
changes can potentially introduce and/or repair security vulnerabilities. I have no idea if this PR does either or both.Scaling Considerations
None
Documentation Considerations
Likely none.
Testing Considerations
Likely none.
Upgrade Considerations
Given that these changes surprised @kriskowal , it would be good to understand what changed on master to cause these.