Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: yarn install before typedoc #1887

Merged
merged 1 commit into from
Dec 6, 2023
Merged

ci: yarn install before typedoc #1887

merged 1 commit into from
Dec 6, 2023

Conversation

turadg
Copy link
Member

@turadg turadg commented Dec 5, 2023

Description

The latest failure (https://github.com/endojs/endo/actions/runs/7107980418/job/19350413938) is that the imports don't resolve:

Run npx typedoc
npm WARN exec The following package was not found and will be installed: typedoc@0.25.4
[info] Converting project at ./packages/base[6](https://github.com/endojs/endo/actions/runs/7107980418/job/19350413938#step:4:7)4
[warning] No entry points were provided, this is likely a misconfiguration.
[info] Converting project at ./packages/bundle-source
[info] Converting project at ./packages/captp
packages/captp/src/atomics.js:1:23 - error TS26[8](https://github.com/endojs/endo/actions/runs/7107980418/job/19350413938#step:4:9)8: Cannot find type definition file for 'ses'.

1 /// <reference types="ses"/>

That's because there was no yarn install. So this does that. No more npx.

Testing Considerations

I did a fresh checkout of the repo and ran npx typedoc to confirm the hypothesis. Then I ran yarn install && yarn docs and that worked.

EDIT: and I discovered that workflow_dispatch lets you pick a branch to load and run a workflow. https://github.com/endojs/endo/actions/runs/7108099837/job/19350750851 shows the site building now, just not deploying because of branch permissions.

@turadg turadg enabled auto-merge December 5, 2023 23:50
@turadg turadg merged commit c64bc4e into master Dec 6, 2023
15 of 16 checks passed
@turadg turadg deleted the ta/fix-typedoc-imports branch December 6, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants