Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated test code #1878

Merged

Conversation

tgrecojs
Copy link
Contributor

@tgrecojs tgrecojs commented Dec 4, 2023

@kumavis i'm not sure what the end goal is for the grain package but i thought this fix might be appreciated.

below is a screenshot of my console from a moment ago. i'm running the test with the -w flag so the passing tests show as soon as the update is saved.

grain-pkg-test-fix

note - you're likely aware of the text below but adding it in for context

this is something i frequently run into when testing hardened js code. ava needs prepare-test-env-ava.js to be the first import. just a guess here but its likely that vscode's prettier extension which automatically rearranges imports so that relative imports follow any dependency import.

@kumavis kumavis merged commit a121a1d into endojs:kumavis-1kce-demo Dec 4, 2023
13 of 14 checks passed
@tgrecojs tgrecojs deleted the tgrecojs-grain-test-imports-fix branch December 4, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants