Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(pass-style): Polish and conslidate property enumeration tables #1869

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

kriskowal
Copy link
Member

This is a drive-by polish of Mark’s property enumeration tables in the pass-style documentation. I maintain that these are high art worthy of exhibition on T-Shirts.

@kriskowal kriskowal requested a review from erights December 1, 2023 00:49
@kriskowal kriskowal force-pushed the kriskowal-property-enumeration-docs branch from d556c86 to 23af02b Compare December 1, 2023 01:02
Copy link
Contributor

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

* **`{k:d*}`** indicates an object mapping keys to property descriptors.

For objects with accessor properties (getters), JavaScript has two modes of
copying, copy-by-value and copy-by-property.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
copying, copy-by-value and copy-by-property.
copying, copy-by-value and copy-by-descriptor.

@kriskowal kriskowal force-pushed the kriskowal-property-enumeration-docs branch from 23af02b to be51fb1 Compare December 1, 2023 19:25
@kriskowal kriskowal merged commit f7979e4 into master Dec 1, 2023
14 checks passed
@kriskowal kriskowal deleted the kriskowal-property-enumeration-docs branch December 1, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants