Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ses): Annotate Promise.withResolvers permit #1852

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

kriskowal
Copy link
Member

Follow-up from #1850. I was hasty.

@kriskowal kriskowal requested a review from erights November 8, 2023 02:23
Copy link
Contributor

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy-n-paste error? Stale clipboard?

@kriskowal kriskowal force-pushed the kriskowal-with-resolvers-permit-annotation branch from 8aae843 to 80e5c33 Compare November 8, 2023 03:11
@kriskowal kriskowal requested a review from erights November 8, 2023 03:11
@kriskowal
Copy link
Member Author

I’ve had better days. Thanks for spotting.

Copy link
Contributor

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kriskowal kriskowal merged commit 1d68400 into master Nov 8, 2023
14 checks passed
@kriskowal kriskowal deleted the kriskowal-with-resolvers-permit-annotation branch November 8, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants