fix(daemon): Strengthen type checks #1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskowal
force-pushed
the
kriskowal-endo-types-baseline
branch
2 times, most recently
from
535063a to
12835ec
Compare
kriskowal
force-pushed
the
kriskowal-endo-types-baseline
branch
from
12835ec to
14d1abc
Compare
kriskowal
commented
Oct 16, 2023
Comment on lines
+50
to
+51
| acks: AsyncSpring<IteratorResult<TRead, TReadReturn>>, | ||
| data: AsyncSink<IteratorResult<TWrite, TWriteReturn>>, |
There was a problem hiding this comment.
I imagine @mhofman will be interested in this relaxation of the signature of makeStream. This is a remnant of the pubsub work. Although we’re not pursuing that variety of pubsub, this does make the type signature of makeStream no more specific than necessary, which I think is good POLA.
kumavis
approved these changes
Oct 17, 2023
| /** | ||
| * @param {object} args | ||
| * @param {string} args.path | ||
| * @param {Promise<unknown>} args.cancelled |
There was a problem hiding this comment.
inconsistent types (see comment above)
here Promise<unknown>
| * @param {object} args | ||
| * @param {number} args.port | ||
| * @param {string} [args.host] | ||
| * @param {Promise<never>} args.cancelled |
There was a problem hiding this comment.
inconsistent types (see comment below)
here Promise<never>
kriskowal
force-pushed
the
kriskowal-endo-types-baseline
branch
from
14d1abc to
2f8aa51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evidently type checks have drifted because
@ts-checkcomments are for some reason not redundant with"checkJs": trueas advertised. This change gets ts-check to pass for all the daemon sources.