feat(pass-style): Use endowed passStyleOf if at global symbol #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
force-pushed
the
markm-symbol-insteadof-VatData
branch
from
9270c52 to
3173bd1
Compare
mhofman
reviewed
Sep 28, 2023
mhofman
approved these changes
Sep 28, 2023
erights
force-pushed
the
markm-symbol-insteadof-VatData
branch
from
3173bd1 to
53658ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement @gibson042 's suggestion at https://github.com/endojs/endo/pull/1676/files#r1264339663 as agreed in the thread starting at Agoric/agoric-sdk#8051 (comment)
An advantage of using a symbol-named property on the global instead of a string-named property is that it is not aliased to a global variable name.