-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(exo)!: extra undeclared args dropped #1765
Conversation
Reviewers, I made this a |
a154713
to
0a06298
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that a) this is technically a breaking change and b) it's unlikely to break anything.
Since the package version hasn't reached 1.0, there's little downside to making a breaking change. So I think keep the !
to err on the side of being loud about it.
0a06298
to
90df09d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
140c470
to
303c114
Compare
303c114
to
9de852b
Compare
Alternative to #1764 experiment.
Of the options listed there, this one
As suggested by @mhofman and @turadg