Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(exo)!: extra undeclared args dropped #1765

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

erights
Copy link
Contributor

@erights erights commented Sep 12, 2023

Alternative to #1764 experiment.

Of the options listed there, this one

Preserve the tolerant behavior, but not pass the values of the extra args through to the protected raw behavior method. This would preserve the input validation intent of method guards while still accommodating API growth and thus version slippage.

As suggested by @mhofman and @turadg

@erights erights self-assigned this Sep 12, 2023
@erights erights requested review from turadg and mhofman September 12, 2023 03:24
@erights
Copy link
Contributor Author

erights commented Sep 12, 2023

Reviewers,

I made this a fix(exo)!: rather than a fix(exo): because it technically is a compat break. However, it is unlikely to currently be a compat break in practice, so let me know if you think I should remove the !.

@erights erights force-pushed the markm-tolerate-hide-extra-args branch from a154713 to 0a06298 Compare September 12, 2023 05:15
Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that a) this is technically a breaking change and b) it's unlikely to break anything.

Since the package version hasn't reached 1.0, there's little downside to making a breaking change. So I think keep the ! to err on the side of being loud about it.

packages/exo/src/exo-tools.js Outdated Show resolved Hide resolved
packages/exo/src/exo-tools.js Outdated Show resolved Hide resolved
packages/exo/src/exo-tools.js Outdated Show resolved Hide resolved
packages/exo/test/test-heap-classes.js Outdated Show resolved Hide resolved
Copy link
Contributor

@mhofman mhofman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/exo/src/exo-tools.js Outdated Show resolved Hide resolved
@erights erights force-pushed the markm-tolerate-hide-extra-args branch 2 times, most recently from 140c470 to 303c114 Compare September 16, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants