fix: review suggestions

endojs · Nov 6, 2023 · 94389ad · 94389ad
1 parent 7460a13
commit 94389ad
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 10 deletions.
diff --git a/packages/exo/src/exo-tools.js b/packages/exo/src/exo-tools.js
@@ -426,9 +426,10 @@ export const defendPrototype = (
     );
   }
 
-  if (interfaceGuard) {
+  if (!hasOwnPropertyOf(prototype, GET_INTERFACE_GUARD)) {
     const getInterfaceGuardMethod = {
       [GET_INTERFACE_GUARD]() {
+        // Note: May be `undefined`
         return interfaceGuard;
       },
     }[GET_INTERFACE_GUARD];
@@ -441,7 +442,12 @@ export const defendPrototype = (
     );
   }
 
-  return Far(tag, /** @type {T} */ (prototype));
+  return Far(
+    tag,
+    /** @type {T & import('./get-interface.js').GetInterfaceGuard<T>} */ (
+      prototype
+    ),
+  );
 };
 harden(defendPrototype);
 

diff --git a/packages/exo/src/get-interface.js b/packages/exo/src/get-interface.js
@@ -15,8 +15,9 @@ export const GET_INTERFACE_GUARD = Symbol.for('getInterfaceGuard');
 /**
  * @template {Record<PropertyKey, CallableFunction>} M
  * @typedef {{
- *   [GET_INTERFACE_GUARD]: () => import('@endo/patterns').InterfaceGuard<{
- *     [K in keyof M]: import('@endo/patterns').MethodGuard
- *   }>
+ *   [GET_INTERFACE_GUARD]: () =>
+ *     import('@endo/patterns').InterfaceGuard<{
+ *       [K in keyof M]: import('@endo/patterns').MethodGuard
+ *     }> | undefined
  * }} GetInterfaceGuard
  */
diff --git a/packages/exo/test/test-exo-class-js-class.js b/packages/exo/test/test-exo-class-js-class.js
@@ -4,8 +4,6 @@
 import { test } from './prepare-test-env-ava.js';
 
 import { passStyleOf } from '@endo/pass-style';
-// import { M, getInterfaceGuardPayload } from '@endo/patterns';
-// import { defineExoClass, makeExo } from '../src/exo-makers.js';
 import { M, getInterfaceGuardPayload } from '@endo/patterns';
 import { makeExo, defineExoClass } from '../src/exo-makers.js';
 

diff --git a/packages/exo/test/test-heap-classes.js b/packages/exo/test/test-heap-classes.js
@@ -172,9 +172,7 @@ test('missing interface', t => {
     message:
       'In "makeSayHello" method of (greeterMaker): result: "[Symbol(passStyle)]" property expected: "[Function <anon>]"',
   });
-  t.throws(() => greeterMaker[GET_INTERFACE_GUARD](), {
-    message: 'greeterMaker[GET_INTERFACE_GUARD] is not a function',
-  });
+  t.is(greeterMaker[GET_INTERFACE_GUARD](), undefined);
 });
 
 const SloppyGreeterI = M.interface('greeter', {}, { sloppy: true });