fix: review suggestions

endojs · Sep 16, 2023 · 8cea5ce · 8cea5ce
1 parent 9bb6315
commit 8cea5ce
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/packages/exo/src/exo-tools.js b/packages/exo/src/exo-tools.js
@@ -35,11 +35,11 @@ const MinMethodGuard = M.call().rest(M.any()).returns(M.any());
 /**
  * @param {Passable[]} args
  * @param {MethodGuardPayload} methodGuardPayload
- * @param {string | undefined} label
+ * @param {string} [label]
  * @returns {Passable[]} Returns the args that should be passed to the
  * raw method
  */
-const defendSyncArgs = (args, methodGuardPayload, label) => {
+const defendSyncArgs = (args, methodGuardPayload, label = undefined) => {
   const { argGuards, optionalArgGuards, restArgGuard } = methodGuardPayload;
   const paramsPattern = M.splitArray(
     argGuards,
@@ -55,6 +55,7 @@ const defendSyncArgs = (args, methodGuardPayload, label) => {
   if (args.length <= declaredLen) {
     return args;
   }
+  // Ignore extraneous arguments, as a JS function call would do.
   return args.slice(0, declaredLen);
 };
 

diff --git a/packages/exo/test/test-heap-classes.js b/packages/exo/test/test-heap-classes.js
@@ -20,7 +20,7 @@ test('what happens with extra arguments', t => {
       t.is(x, undefined);
     },
   });
-  exo.foo(8);
+  exo.foo('an extra arg');
 });
 
 const UpCounterI = M.interface('UpCounter', {