fix: Appease lint harder

endojs · Jan 24, 2024 · 4b3573a · 4b3573a
1 parent 4ece3f8
commit 4b3573a
Show file tree

Hide file tree

Showing 7 changed files with 17 additions and 8 deletions.
diff --git a/packages/cli/src/client.js b/packages/cli/src/client.js
@@ -1,9 +1,16 @@
 import { start, makeEndoClient } from '@endo/daemon';
 
-export const provideEndoClient = async (...args) => {
+/**
+ * @template TBootstrap
+ * @param {string} name
+ * @param {string} sockPath
+ * @param {Promise<void>} cancelled
+ * @param {TBootstrap} [bootstrap]
+ */
+export const provideEndoClient = async (name, sockPath, cancelled, bootstrap) => {
   try {
     // It is okay to fail to connect because the daemon is not running.
-    return await makeEndoClient(...args);
+    return await makeEndoClient(name, sockPath, cancelled, bootstrap);
   } catch {
     console.error('Starting Endo daemon...');
     // It is also okay to fail the race to start.
@@ -12,6 +19,6 @@ export const provideEndoClient = async (...args) => {
     // We are not going to contemplate reliably in the face of a worker getting
     // stopped the moment after it was started.
     // That is a bridge too far.
-    return makeEndoClient(...args);
+    return makeEndoClient(name, sockPath, cancelled, bootstrap);
   }
 };
diff --git a/packages/cli/src/install.js b/packages/cli/src/install.js
@@ -18,7 +18,7 @@ export const install = async ({
   webPageName,
   programPath,
 }) => {
-  /** @type {import('@endo/eventual-send').ERef<import('@endo/stream').Reader<string>> | undefined} */
+  /** @type {import('@endo/eventual-send').FarRef<import('@endo/stream').Reader<string>> | undefined} */
   let bundleReaderRef;
   /** @type {string | undefined} */
   let temporaryBundleName;

diff --git a/packages/cli/src/make.js b/packages/cli/src/make.js
@@ -40,7 +40,7 @@ export const makeCommand = async ({
     return;
   }
 
-  /** @type {import('@endo/eventual-send').ERef<import('@endo/stream').Reader<string>> | undefined} */
+  /** @type {import('@endo/eventual-send').FarRef<import('@endo/stream').Reader<string>> | undefined} */
   let bundleReaderRef;
   /** @type {string | undefined} */
   let temporaryBundleName;

diff --git a/packages/daemon/src/client.js b/packages/daemon/src/client.js
@@ -9,7 +9,7 @@ import { makeNetstringCapTP } from './connection.js';
  * @param {string} name
  * @param {string} sockPath
  * @param {Promise<void>} cancelled
- * @param {TBootstrap=} bootstrap
+ * @param {TBootstrap} [bootstrap]
  */
 export const makeEndoClient = async (name, sockPath, cancelled, bootstrap) => {
   const conn = net.connect(sockPath);

diff --git a/packages/daemon/src/daemon-node.js b/packages/daemon/src/daemon-node.js
@@ -153,6 +153,7 @@ const main = async () => {
 
 process.once('SIGINT', () => cancel(new Error('SIGINT')));
 
+// @ts-ignore Yes, we can assign to exitCode, typedoc.
 process.exitCode = 1;
 main().then(
   () => {

diff --git a/packages/daemon/src/reader-ref.js b/packages/daemon/src/reader-ref.js
@@ -10,7 +10,7 @@ import { Far } from '@endo/far';
  *
  * @template T The item type of the iterable.
  * @param {import('./types').SomehowAsyncIterable<T>} iterable The iterable object.
- * @returns {import('@endo/stream').Stream<T>} sort of fudging this into a stream to appease "mapReader"
+ * @returns {import('@endo/stream').Reader<T>} sort of fudging this into a stream to appease "mapReader"
  */
 export const asyncIterate = iterable => {
   let iterator;
@@ -61,7 +61,7 @@ export const makeIteratorRef = iterable => {
 
 /**
  * @param {import('./types').SomehowAsyncIterable<Uint8Array>} readable
- * @returns {import('@endo/far').FarRef<import('@endo/stream').Stream<string>>}
+ * @returns {import('@endo/far').FarRef<import('@endo/stream').Reader<string>>}
  */
 export const makeReaderRef = readable =>
   makeIteratorRef(mapReader(asyncIterate(readable), encodeBase64));
diff --git a/packages/daemon/src/worker-node.js b/packages/daemon/src/worker-node.js
@@ -42,6 +42,7 @@ const { promise: cancelled, reject: cancel } =
 
 process.once('SIGINT', () => cancel(new Error('SIGINT')));
 
+// @ts-ignore Yes, we can assign to exitCode, typedoc.
 process.exitCode = 1;
 main(powers, locator, workerUuid, process.pid, cancel, cancelled).then(
   () => {