Skip to content

Commit

Permalink
fix(ses): review suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
erights committed Jan 16, 2024
1 parent c731931 commit 0449938
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion packages/ses/test/test-tame-faux-data-properties.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,15 @@ test('unit test tameFauxDataProperty', t => {
defineProperty(this, 'foo', { value: newValue });
},
};
t.is(tfdp(subject2, 'foo', 'bar'), false);
// This setter is not behaving like a proper setter for
// enabling property overrides, so we would prefer that the answer
// immediately below be `false` instead of `true`. But we
// commented out the test in tame-faux-data-properties.js
// because we cannot be confident it won't cause persistent
// side effects.
// We include the test anyway, to document that this case does
// pass, and to become aware if it stops passing.
t.is(tfdp(subject2, 'foo', 'bar'), true);

const subject3 = {
get foo() {
Expand Down

0 comments on commit 0449938

Please sign in to comment.