-
-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add support for ICS Files #755
Conversation
Thanks for opening this pull request! Please check out our contributing guidelines. If you are working on site internals, see https://github.com/endoflife-date/endoflife.date/blob/master/HACKING.md |
Looks great! A few suggestions:
|
Few suggestions for calendar text:
A Thanks a lot for the PR, this is gonna be very helpful 🥇! |
Thank you for your quick review.
I added calendar link in template file.
I edited _headers, _redirects.
Could you explain what I should do?
It seems icalendar doesn't accept multiple urls.
I added description like that except for the
There are products which has release date but not eol date: android, go, macos, etc.
I got feedback and fixed it. |
Any update? |
I'll review and merge this soon. I just want to test this with more than a few clients (haven't tested on iOS/Android yet). |
@captn3m0 ^^ ping ? [ also there are some merge conflicts exist right now ] |
The link on https://deploy-preview-755--endoflife-date.netlify.app/wagtail links to Works well on Apple calendar otherwise. The event name being "Wagtail 2.13 EOL" would also be superior to just "EOL 2.13" -- the description of "Wagtail 2.13 will become End-of-life." is good though. I don't see a link to endoflife.date, though, only to the Wagtail release schedule at https://github.com/wagtail/wagtail/wiki/Release-schedule Very excited for this feature! |
@captn3m0 ping ? what is the situation about this PR ? |
This PR is rather old. I just rebased it from master resolved the conflicts. |
@dragon-dxw, links have been fixed (during rebase ?) and events titles updated from |
@captn3m0, I reviewed the code and made some tests. I think we are ready to release a beta of this feature. Let me know if you need some help for something. |
New conflicts introduced by #2031 resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but conflicts need fixing.
Here is the template to use if later we want to implement Jekyll Generator instead : https://gist.github.com/woodworker/6725728. |
Thank you and congratulations for your first contribution! endoflife.date is a community wiki, and we're always looking for more contributions 🥇 💯 🎉. |
@rikuson, it took some time but it's finally merged! Thanks a lot for your contribution. |
Done #59
There's issue that it can not set absolute value to icalendar's trigger.
So I just set 365days, 182days, 90days, 30days to notify 1 year, 6 months, 3 months and 1 month for now.
I'm working on the issue.