debian: Add dependency on eos-metrics-0-dev for downstream metrics #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philip Withnall <withnall@endlessm.com> https://phabricator.endlessm.com/T28742
pwithnall
added a commit
that referenced
this pull request
Oct 20, 2020
Instead of removing all the entries in the list store when the set of installed apps is updated, diff the old and new lists so that removed apps can be selectively removed from the list store, and added apps can be selectively added. This means that we can (in subsequent commits) reload the app list less conservatively, as doing so will no longer remove in-progress user modifications to the set of blocked apps. Modifications are still only saved when the restrict applications dialogue is closed. Signed-off-by: Philip Withnall <pwithnall@endlessos.org> Helps: #18, #28
pwithnall
added a commit
that referenced
this pull request
Oct 20, 2020
This will no longer destroy in-progress user input. Signed-off-by: Philip Withnall <pwithnall@endlessos.org> Fixes: #18
pwithnall
added a commit
that referenced
this pull request
Dec 9, 2020
Instead of removing all the entries in the list store when the set of installed apps is updated, diff the old and new lists so that removed apps can be selectively removed from the list store, and added apps can be selectively added. This means that we can (in subsequent commits) reload the app list less conservatively, as doing so will no longer remove in-progress user modifications to the set of blocked apps. Modifications are still only saved when the restrict applications dialogue is closed. Signed-off-by: Philip Withnall <pwithnall@endlessos.org> Helps: #18, #28
pwithnall
added a commit
that referenced
this pull request
Dec 9, 2020
This will no longer destroy in-progress user input. Signed-off-by: Philip Withnall <pwithnall@endlessos.org> Fixes: #18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Philip Withnall withnall@endlessm.com
https://phabricator.endlessm.com/T28742
Code changes in #17.