Exception table diff view #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CelestialAmber
changed the title
Needs lotsa work
encounter
reviewed
Jul 22, 2024
| /* Get the function symbol and extab symbol from the extabindex relocations array. Each extabindex | ||
| entry has two relocations (the first for the function, the second for the extab entry) */ | ||
| let extab_func = extabindex_section.relocations[i * 2].target.clone(); | ||
| let extab = &extabindex_section.relocations[(i * 2) + 1].target; |
There was a problem hiding this comment.
Seems dangerous to assume the index of relocations. Can we fetch these by either source address or target symbol?
| let mut dtors: Vec<ObjSymbol> = vec![]; | ||
|
|
||
| while extab_reloc_index < extab_reloc_count { | ||
| let extab_reloc = &extab_section.relocations[extab_reloc_index]; |
There was a problem hiding this comment.
Can we also sanity check that these are Absolute relocations? In case something else sneaks in... not sure how though
|
One lingering issue is that this will break builds without feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new view which shows the decoded exception tables (extab) for functions which have them, accessible via an option in the right click context menu. The decoded data is listed out as plain text on both sides for both objects, much like the other diff views. No form of diffing is implemented yet, but to start out with we could use text diffing for now, and maybe later on transition to displaying the data in a fancier way that could more easily be diffed.