Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip distro root prefix #58

Merged
merged 1 commit into from
May 16, 2024
Merged

Strip distro root prefix #58

merged 1 commit into from
May 16, 2024

Conversation

AetiasHax
Copy link
Contributor

Building on WSL uses wsl --cd <dir> ... which expects a Windows/Linux path and doesn't work with \\wsl.localhost paths. I fixed this by stripping the prefix \\wsl.localhost\{distro} and replacing it with the root path /.

@encounter
Copy link
Owner

Thanks for the PR! I was under the impression that wsl.exe properly translated \\wsl.localhost paths. What error were you getting before this?

@encounter
Copy link
Owner

Ah, just tested and it doesn't handle it. Good catch!

@encounter encounter merged commit db726a6 into encounter:main May 16, 2024
10 checks passed
@AetiasHax AetiasHax deleted the wsl-root branch May 16, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants