Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix added/removed bytes being visually misaligned in data diff view #159

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

LagoLunatic
Copy link
Contributor

diff.len / 8 doesn't always catch when the 8-byte column midpoint is passed since e.g. when cur_addr=4 diff.len=5 neither one of those are greater than 8 individually, but are combined.

Before:
image

After:
image

@encounter
Copy link
Owner

Thank you! This has long annoyed me (and I’m sure others 🙂)

@encounter encounter merged commit 6b7dcab into encounter:main Jan 25, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants