Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coff line number #100

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Coff line number #100

merged 2 commits into from
Sep 5, 2024

Conversation

roblabla
Copy link
Contributor

@roblabla roblabla commented Sep 4, 2024

Fixes #55

This turned out to be fairly straightforward once I figured out how on earth those line numbers really worked. I tried to comment everything so it should be clear what's going on, but if you need more information or something feels unclear, feel free to ask and I'll see if I can improve the comments to make it clearer.

Copy link
Owner

@encounter encounter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the impl! I wasn't really looking forward to figuring this out on my own. 😆 Code looks great, and I appreciate the documentation.

I use nightly fmt options so you can do cargo +nightly fmt to resolve the issues.

@roblabla
Copy link
Contributor Author

roblabla commented Sep 4, 2024

Formatting should be fixed.

@encounter encounter merged commit a32d999 into encounter:main Sep 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support COFF line numbers
2 participants