Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtimes/core: use path param types #1261

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

eandre
Copy link
Member

@eandre eandre commented Jun 11, 2024

This is more robust now that we've improved the type parser

@eandre eandre requested a review from fredr June 11, 2024 10:05
@encore-cla
Copy link

encore-cla bot commented Jun 11, 2024

All committers have signed the CLA.

fredr
fredr previously approved these changes Jun 11, 2024
Copy link
Member

@fredr fredr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@eandre eandre force-pushed the path-param-types branch 2 times, most recently from bddbb4e to 1cb5455 Compare June 11, 2024 11:53
This is more robust now that we've improved the type parser
@eandre eandre force-pushed the path-param-types branch from 1cb5455 to 3fa6593 Compare June 11, 2024 12:40
@eandre eandre requested a review from fredr June 11, 2024 12:50
@eandre eandre enabled auto-merge (rebase) June 11, 2024 12:51
@eandre eandre merged commit e768135 into encoredev:main Jun 11, 2024
4 checks passed
@eandre eandre deleted the path-param-types branch June 11, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants