Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typescript: add logs to traces #1248

Merged
merged 11 commits into from
Jun 7, 2024
Merged

typescript: add logs to traces #1248

merged 11 commits into from
Jun 7, 2024

Conversation

fredr
Copy link
Member

@fredr fredr commented Jun 5, 2024

Adds logs rows to traces in typescript

@fredr fredr requested a review from eandre June 5, 2024 13:05
@fredr fredr self-assigned this Jun 5, 2024
runtimes/core/src/model/mod.rs Outdated Show resolved Hide resolved
Copy link
Member

@eandre eandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks great! A few minor nitpicks :)

runtimes/core/src/log/logger.rs Outdated Show resolved Hide resolved
runtimes/core/src/log/logger.rs Outdated Show resolved Hide resolved
runtimes/core/src/model/mod.rs Outdated Show resolved Hide resolved
runtimes/core/src/trace/protocol.rs Outdated Show resolved Hide resolved
@fredr fredr force-pushed the fredr/ts-log-in-trace branch from 5bf97e7 to 3197e55 Compare June 7, 2024 08:00
@encore-cla
Copy link

encore-cla bot commented Jun 7, 2024

All committers have signed the CLA.

@fredr fredr force-pushed the fredr/ts-log-in-trace branch from 3197e55 to 04c9845 Compare June 7, 2024 08:18
@fredr fredr enabled auto-merge (squash) June 7, 2024 12:11
@fredr fredr merged commit 5961768 into main Jun 7, 2024
4 checks passed
@fredr fredr deleted the fredr/ts-log-in-trace branch June 7, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants