Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add If 0, a random port is used. #1983

Merged
merged 3 commits into from
May 31, 2023

Conversation

Hiroshiba
Copy link
Contributor

Summary

Added to the documentation that if 0 is specified for the port number, a random port number is used.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)

@Kludex
Copy link
Member

Kludex commented May 27, 2023

You'll need to run ./scripts/lint. 🙏

@Kludex
Copy link
Member

Kludex commented May 29, 2023

You'll need to run ./scripts/lint. 🙏

@Hiroshiba

@Hiroshiba
Copy link
Contributor Author

Done!

@@ -33,7 +33,8 @@ Usage: uvicorn [OPTIONS] APP
Options:
--host TEXT Bind socket to this host. [default:
127.0.0.1]
--port INTEGER Bind socket to this port. [default: 8000]
--port INTEGER Bind socket to this port. If 0, a random
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the following sentence instead, please:

"Bind socket to this port. If 0, an available port will be picked."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not random per se. 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kludex I agree with your suggestion and have made the necessary changes. Thank you for your assistance.

@Kludex
Copy link
Member

Kludex commented May 31, 2023

Thanks

@Kludex Kludex merged commit f764e50 into encode:master May 31, 2023
@Hiroshiba Hiroshiba deleted the If-0-a-random-port-is-used branch May 31, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants