Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop trio from test suite #2836

Closed
wants to merge 2 commits into from
Closed

Drop trio from test suite #2836

wants to merge 2 commits into from

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented Jan 1, 2025

The motivation here is that I don't believe having trio on the test suite is necessary.

anyio is the compatibility layer, and testing that both behave the same is supposed to be on that side.

@Kludex
Copy link
Member Author

Kludex commented Jan 1, 2025

I don't understand why 3.11 fails but 3.10 doesn't.

@Kludex
Copy link
Member Author

Kludex commented Jan 1, 2025

why only 3.11? o.o

@graingert
Copy link
Member

graingert commented Jan 1, 2025

  • this saves like 1 second in CI? seems not worth it.
  • It's also useful to be able to run on both trio and asyncio to see if something's an anyio bug - because usually it will pass in trio and fail strangely on asyncio.
  • Also I just like having trio around as a test dep here, I think it's an important message

@Kludex
Copy link
Member Author

Kludex commented Jan 1, 2025

this saves like 1 second in CI? seems not worth it.

It's more because conceptually, anyio the compatibility layer.

Although locally, having 2 outputs for each test is annoying.


If I open this PR, it's because it bothered me to the point to open it. But I don't think it's worth it.

@Kludex Kludex closed this Jan 1, 2025
@Kludex Kludex deleted the drop-trio-from-test-suite branch January 1, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants