Add query parameters

starlette/requests.py

@@ -172,10 +172,15 @@ def state(self) -> State:
             self._state = State(self.scope["state"])
         return self._state
 
-    def url_for(self, name: str, **path_params: typing.Any) -> str:
+    def url_for(
+        self, name: str, query_params: dict = None, **path_params: typing.Any
+    ) -> str:
         router: Router = self.scope["router"]
         url_path = router.url_path_for(name, **path_params)
-        return url_path.make_absolute_url(base_url=self.base_url)
+        absolute_url = URL(url_path.make_absolute_url(base_url=self.base_url))
+        if query_params:
+            absolute_url = absolute_url.include_query_params(**query_params)
+        return absolute_url._url
 
 
 async def empty_receive() -> typing.NoReturn:

tests/test_routing.py

@@ -4,6 +4,7 @@
 import pytest
 
 from starlette.applications import Starlette
+from starlette.requests import Request
 from starlette.responses import JSONResponse, PlainTextResponse, Response
 from starlette.routing import Host, Mount, NoMatchFound, Route, Router, WebSocketRoute
 from starlette.websockets import WebSocket, WebSocketDisconnect
@@ -700,3 +701,21 @@ def test_duplicated_param_names():
         match="Duplicated param names id, name at path /{id}/{name}/{id}/{name}",
     ):
         Route("/{id}/{name}/{id}/{name}", user)
+
+
+def test_url_for_with_query_params(test_client_factory):
+    def echo_queryparams_urls(request: Request):
+        return JSONResponse(
+            {
+                "queryparams": request.url_for("index", query_params={"Foo": "Bar"}),
+            }
+        )
+
+    routes = [Route("/", echo_queryparams_urls, name="index", methods=["GET"])]
+    app = Starlette(routes=routes)
+    client = test_client_factory(app)
+    response = client.get("/")
+
+    assert response.json() == {
+        "queryparams": "http://testserver/?Foo=Bar",
+    }