Skip to content

Commit

Permalink
Remove mypy skip flags (#2497)
Browse files Browse the repository at this point in the history
* Remove flags

* Apply suggestions from code review

* Remove mypy overrides

---------

Co-authored-by: Scirlat Danut <scirlatdanut@scirlats-mini.lan>
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
  • Loading branch information
3 people authored Feb 9, 2024
1 parent ac7e643 commit f724827
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 10 deletions.
8 changes: 0 additions & 8 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,6 @@ python_version = "3.8"
module = "starlette.testclient.*"
implicit_optional = true

# TODO: Uncomment the following configuration when
# https://github.com/python/mypy/issues/10045 is solved. In the meantime,
# we are calling `mypy tests` directly. Check `scripts/check` for more info.
# [[tool.mypy.overrides]]
# module = "tests.*"
# disallow_untyped_defs = false
# check_untyped_defs = true

[tool.pytest.ini_options]
addopts = "-rxXs --strict-config --strict-markers"
xfail_strict = true
Expand Down
3 changes: 1 addition & 2 deletions scripts/check
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,5 @@ set -x
${PREFIX}ruff format --check --diff $SOURCE_FILES
# TODO: Use `[[tool.mypy.overrides]]` on the `pyproject.toml` when the mypy issue is solved:
# github.com/python/mypy/issues/10045. Check github.com/encode/starlette/pull/2180 for more info.
${PREFIX}mypy starlette
${PREFIX}mypy tests --disable-error-code no-untyped-def --disable-error-code no-untyped-call
${PREFIX}mypy $SOURCE_FILES
${PREFIX}ruff check $SOURCE_FILES

0 comments on commit f724827

Please sign in to comment.