Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress examples #1272

Merged
merged 3 commits into from
Sep 10, 2020
Merged

Progress examples #1272

merged 3 commits into from
Sep 10, 2020

Conversation

tomchristie
Copy link
Member

What do we think about this?...

  • Include a progress bar using rich, in addition to the existing one using tqdm.
  • Include GIF images demonstrating the running examples.

Rendered docs look like this...

xhb8nB5zRt

@tomchristie tomchristie added the docs Changes to the documentation label Sep 10, 2020
Copy link
Member

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome sauce 😍

@tomchristie tomchristie merged commit 59074c7 into master Sep 10, 2020
@tomchristie tomchristie deleted the progress-examples branch September 10, 2020 11:28
@tomchristie
Copy link
Member Author

Incidentally it looked to me like the download speed displayed by rich was much more jumpy than I'd expected. It might? be worth looking into if there's any buglette hidden in there, to do how they're calculating it based on the update samples.

A quick pass looked as if they're averaging it out over the last 30 seconds, but I would have expected a smoother rate of change from what I actually saw.

But perhaps I've got my wires crossed - didn't get a chance to dig much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Changes to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants