Fix synchronous TLS-in-TLS streams #840
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #841
I'm not sure how we missed that, but it appears we have an if statement that prevents
TLS-in-TLS
streams for synchronous backends.@tomchristie included a basic example of how to test this feature in sync and async code in the pull request that adds HTTPS proxy support.
This pull request simply corrects
TLS-in-TLS
sync by removing unnecessary if. To test locally, follow the steps outlined in the PR that adds HTTPS proxy support.